Rename boilerplate to kernel folder #16
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rename boilerplate to kernel folder and bump the version.
Develop branch is updated, remote PR can be made after accepting the PR to master.
2 files called
LICENSEare not updated due to the "boilerplate" word being part of the Apache License text.3 tests for building side loaded applications failed for
app-ethereuminstax.app-ethereumis probably using newer version ofnbgl_getTextMaxLenInNbLinesthat supports 6 parameters instead of 5, so the building of the application fails with the currentstaxenvironment in the docker.https://github.com/LedgerHQ/app-ethereum/blob/develop/src_nbgl/ui_sign_message.c#L46-L51
The docker is maintained by
LedgerHQ, so the fix for those tests doesn't look likeQtumresponsibility.nbgl_getTextMaxLenInNbLinesis not used inapp-qtum, so it's potential update has no impact forapp-qtum.